Fix flaky categorical concat test#12276
Conversation
On minimal pandas versions, concatenation of categorical data does not guarantee stable ordering of values, even when categories and dtypes match. The test was asserting positional equality for categorical Series, which is stronger than the guarantees provided by pandas and leads to frequent failures in mindeps-optional.
On minimal pandas versions, concatenation of categorical data does not guarantee stable ordering of values, even when categories and dtypes match. The test was asserting positional equality for categorical Series, which is stronger than the guarantees provided by pandas and leads to frequent failures in mindeps-optional.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files ±0 21 suites ±0 5h 11m 31s ⏱️ +51s Results for commit 8df9027. ± Comparison against base commit 2bb80d7. ♻️ This comment has been updated with latest results. |
|
Looks like you have a merge mash in your PR; I see multiple copies of the same code blocks |
i had an internet issue yesterday.. |
Removed duplicate check_and_return function and redundant assertions for categorical values in the test cases.
|
Looks like everything is green now. Thank you for reviewing!! |
|
Let's see how this goes long term. Thank you! |
test_concat_categorical#12268pre-commit run --all-files