Preliminary Python 3.14t support#12223
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files + 2 21 suites +2 5h 13m 39s ⏱️ + 9m 28s Results for commit a642b8d. ± Comparison against base commit 08f5daa. ♻️ This comment has been updated with latest results. |
|
CI failures are unrelated. |
|
I see this failure that looks pertinent when I try to run the dask unit tests locally on my ARM Mac on this PR branch with free-threaded 3.14: I also see a few other test failures that look unrelated: I got impatient and killed the tests in |
Are you on numpy git tip? Do you get the same failures with 2.4.1? What about the nightly wheels?
Thanks; I think the reason CI didn't spot this yet is that numpy nightly wheels are lagging a bit behind git tip?
Any idea why these don't show up on 3.14 with pandas nightly? Similar lag issue as above? |
Yup, NumPy is built from source. The failure seems to be flaky, it only happened the first time I ran the tests not the second time after I installed optional dependencies. Now that I'm trying just that one test repeatedly, it seems to fail about half of the times I try to run it. I can trigger it with the 2.4.1 NumPy wheel from PyPI. FWIW, I see no crashes in Pandas. Maybe try uncommenting Pandas to see if any of the CI runners hit the crash?
Yeah, the deprecation just got merged today so no surprise there.
No idea, sorry. |
|
@jacobtomlinson @jsignell does either of you have bandwidth to offer review? |
|
With pandas 3.0 final I'm getting these failures I'd rather investigate them in a follow-up to avoid scope creep. |
jsignell
left a comment
There was a problem hiding this comment.
Looks good to me, I approved #12224 (review) as well, but just have the question about performance.
distributed, currently needs a very ugly hack. This is being tracked upstream (Builds on no-GIL interpreters, but not fully supported yet msgpack/msgpack-python#613). As I was forced to install it in pure-python mode, I would advise against running benchmarks until the C extension becomes available.Programming Language :: Python :: Free Threading :: 1 - Unstable. Technically it's known broken for dask.dataframe and2 - Betafor everything else. I will bump the flag to2 - Betaonce pandas fixes the race conditions upstream and we can reintroduce it to the CI environment. Also probably a good idea to wait for a hack-free msgpack before we indicate a good user experience.This PR incorporates and is blocked by #12224. This PR only adds the last commit 208891b.