Skip to content

[CI] unbreak codecov#12211

Merged
crusaderky merged 2 commits intodask:mainfrom
crusaderky:codecov
Dec 31, 2025
Merged

[CI] unbreak codecov#12211
crusaderky merged 2 commits intodask:mainfrom
crusaderky:codecov

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky commented Dec 30, 2025

There are three distinct problems with codecov:

  1. I found it to be configured (for dask/dask only) to use master as the primary branch. I've already fixed this in the control panel.
  2. It has failed on pushes to main for the last year, with the message
error - 2025-12-30 22:27:57,030 -- Upload failed: {"message":"Token required because branch is protected"}

The result is that both the aggregated % and the final report in PRs are nonsensical, as they run on the delta from main as of 1 year ago.

  1. codecov becomes transitorily red while CI is running. It should only post its output after all gha jobs have completed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 30, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   4h 51m 38s ⏱️ + 22m 3s
 18 161 tests ±0   16 945 ✅ +2   1 216 💤 ±0  0 ❌  - 2 
271 003 runs  ±0  251 116 ✅ ±0  19 887 💤 +2  0 ❌  - 2 

Results for commit 1c54866. ± Comparison against base commit 7ab8bc2.

♻️ This comment has been updated with latest results.

@crusaderky crusaderky changed the title WIP [CI] make codecov meaningful again WIP [CI] codecov misses its target for PRs Dec 30, 2025
@crusaderky crusaderky changed the title WIP [CI] codecov misses its target for PRs WIP [CI] unbreak codecov Dec 31, 2025
@crusaderky crusaderky closed this Dec 31, 2025
@crusaderky crusaderky reopened this Dec 31, 2025
@crusaderky crusaderky changed the title WIP [CI] unbreak codecov [CI] unbreak codecov Dec 31, 2025
@crusaderky crusaderky marked this pull request as ready for review December 31, 2025 17:00
@crusaderky crusaderky merged commit c9e23e5 into dask:main Dec 31, 2025
37 of 57 checks passed
@crusaderky crusaderky deleted the codecov branch December 31, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant