Support min/max of datetime#12183
Conversation
TomAugspurger
left a comment
There was a problem hiding this comment.
LGTM assuming the tests pass. Thanks.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files + 4 9 suites +4 3h 9m 15s ⏱️ + 1h 38m 44s Results for commit 1597f27. ± Comparison against base commit b1098a4. ♻️ This comment has been updated with latest results. |
|
The existing tests pass without alteration, I'll add a few more to prove that this PR actually makes it possible to take the min/max of an array of datetimes. |
jacobtomlinson
left a comment
There was a problem hiding this comment.
Good to see you @jsignell! Thanks for this.
Appreciate the review @TomAugspurger
pre-commit run --all-filesI just came across pydata/xarray#5001 which led me to #6354. It seems like at this point there is enough
metamanipulation going on within the Array instantiation that happens after this piece of code that you don't really need to manipulate the dimensionality of themetaat all.