Merged
Conversation
pandas 3.x changed the unit resolution (ns. vs. us) for strings. This
test does a `DatetimeIndex + Timedelta`. Previously both those used
ns resolution. Now `pd.date_range(...)` get `us` resoultion, while
`Timedelta(days=1)` gets `ns` resolution. Then we tried to append a
us-resolution index to a ns-resolution index, and got an error.
Fixed by changing to `Timdelta("1D")` to get `us` for both.
Fixes errors like `dask/dataframe/io/tests/test_parquet.py::test_append_overlapping_divisions`.
Fixes errors like `dask/dataframe/dask_expr/tests/test_collection.py::test_shift_with_freq_TimedeltaIndex`.
Fixes errors like `dask/dataframe/tests/test_arithmetics_reduction.py::test_reductions_non_numeric_dtypes`.
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files ±0 9 suites ±0 3h 12m 25s ⏱️ +5s Results for commit a2b9ef2. ± Comparison against base commit 2f2d099. ♻️ This comment has been updated with latest results. |
# with '#' will be ignored, and an empty message aborts the commit. # # On branch tom/upstream-compat-3 # Your branch is up to date with 'origin/tom/upstream-compat-3'. # # Changes to be committed: # modified: dask/dataframe/tests/test_utils_dataframe.py # # Untracked files: # a.parquet # data.parquet/ # debug.py # ds.parquet/ # failures.md # nation.impala.parquet # out.log # out.parquet/ # string.parquet/ # test.parquet # test_bug.py #
Member
Author
|
This should be ready for review @jacobtomlinson or @jrbourbeau if either of you have a chance. The errors from my last run are here. a2b9ef2 fixes the first error and the remainder are resample errors and will hopefully be resolved by pandas-dev/pandas#63262. The outstanding item is mentioned in #12178 (comment) for how we ought to handle unit inference in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12178. I still need to handle the resample failures.
See the commit messages for details.