Skip to content

Document groupby: split_every, split_out#12135

Merged
jacobtomlinson merged 13 commits intodask:mainfrom
jayeshmanani:dockstring-groupby
Nov 12, 2025
Merged

Document groupby: split_every, split_out#12135
jacobtomlinson merged 13 commits intodask:mainfrom
jayeshmanani:dockstring-groupby

Conversation

@jayeshmanani
Copy link
Copy Markdown
Contributor

@jayeshmanani jayeshmanani commented Nov 4, 2025


Result of pre-commit run --all-files

fix end of files.........................................................Passed
debug statements (python)................................................Passed
absolufy-imports.........................................................Passed
ruff check...............................................................Passed
isort....................................................................Passed
black....................................................................Passed
codespell................................................................Passed
mypy.....................................................................Passed

@jayeshmanani jayeshmanani changed the title Update: Dockstring groupby: split_every, split_out Update: Dockstring groupby: split_every, split_out - Fix: #6386 Nov 4, 2025
@jayeshmanani jayeshmanani changed the title Update: Dockstring groupby: split_every, split_out - Fix: #6386 Fix #6386 - Update: Dockstring groupby: split_every, split_out Nov 4, 2025
@jayeshmanani jayeshmanani changed the title Fix #6386 - Update: Dockstring groupby: split_every, split_out Fixes #6386 - Update: Dockstring groupby: split_every, split_out Nov 4, 2025
@jayeshmanani jayeshmanani changed the title Fixes #6386 - Update: Dockstring groupby: split_every, split_out Fixes #6386 - Dockstring groupby: split_every, split_out Nov 4, 2025
@jayeshmanani jayeshmanani changed the title Fixes #6386 - Dockstring groupby: split_every, split_out Related to #6386 - Dockstring groupby: split_every, split_out Nov 4, 2025
@jayeshmanani
Copy link
Copy Markdown
Contributor Author

Related to #6386

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

      9 files  ±  0        9 suites  ±0   3h 12m 50s ⏱️ - 2m 47s
 18 154 tests + 15   16 939 ✅ + 17   1 215 💤 ±0  0 ❌  - 2 
162 614 runs  +135  150 518 ✅ +136  12 096 💤 +1  0 ❌  - 2 

Results for commit 4b9017b. ± Comparison against base commit 74ad214.

♻️ This comment has been updated with latest results.

@jacobtomlinson jacobtomlinson changed the title Related to #6386 - Dockstring groupby: split_every, split_out Document groupby: split_every, split_out Nov 6, 2025
Copy link
Copy Markdown
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jayeshmanani.

@VibhuJawa as you opened the original issue would you mind taking a look?

cc @gforsyth who was also involved in that discussion

Copy link
Copy Markdown
Contributor

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, had a suggestion about adding back default values.

Copy link
Copy Markdown
Contributor

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @VibhuJawa

@jacobtomlinson jacobtomlinson merged commit 9ff957f into dask:main Nov 12, 2025
23 of 24 checks passed
@jayeshmanani jayeshmanani deleted the dockstring-groupby branch November 12, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Add docstring for split_out and split_every in dask groupby-aggregate API

3 participants