Replace versioneer with setuptools-scm#12133
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files ±0 9 suites ±0 3h 7m 40s ⏱️ - 7m 44s For more details on these failures, see this check. Results for commit 38fd9a1. ± Comparison against base commit 88fd00d. ♻️ This comment has been updated with latest results. |
|
Sorry @DimitriPapadopoulos I totally missed #12039 when you originally opened it, probably because it's still a draft. |
|
|
||
| try: | ||
| # Backwards compatibility with versioneer | ||
| from dask._version import __commit_id__ as __git_revision__ |
There was a problem hiding this comment.
__commit_id__ was only added in setuptools-scm 9, and since this is in the same try, it means it's required to get a functional dask version. Should the setuptools-scm dependency get a minimum version, or should this try block be split so that it's optional?
There was a problem hiding this comment.
In future please open a new issue instead of commenting on closed PRs. We probably need a minimum version.
Given that
setuptools-scmis more widely used and better maintained thanversioneer(last release was July 2023) we might want to switch.pyproject.tomlto usesetuptools-scmdask/_version.pyfile assetuptools-scmgenerates this during sdist/wheel build (orpip install -e .)dask/dataframe/dask_expr/_version.pyas this looked unused