Update np.accumulate workaround comment#12129
Merged
jrbourbeau merged 1 commit intodask:mainfrom Nov 3, 2025
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files ±0 9 suites ±0 3h 11m 9s ⏱️ + 3m 16s Results for commit ba74884. ± Comparison against base commit 17a245a. |
dcherian
approved these changes
Nov 3, 2025
jrbourbeau
approved these changes
Nov 3, 2025
np.accumulate workaround comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though numpy/numpy#30104 is merged we still need to maintain our workaround for numpy/numpy#30095 until our minimum numpy version is higher than
2.3.4.This PR updates the comment in the workaround to make it clear when the workaround can be removed by some future maintainer.