Skip to content

Fix deprecated quantile 'interpolation' being passed to numpy#12108

Merged
jrbourbeau merged 3 commits intodask:mainfrom
djhoese:bugfix-quantile-interp
Oct 24, 2025
Merged

Fix deprecated quantile 'interpolation' being passed to numpy#12108
jrbourbeau merged 3 commits intodask:mainfrom
djhoese:bugfix-quantile-interp

Conversation

@djhoese
Copy link
Copy Markdown
Contributor

@djhoese djhoese commented Oct 24, 2025

Side note: My IDE let me know that overwrite_input is never used which makes sense as far as dask not wanting inputs to be modified, but maybe it should be warned/errored if provided?

@djhoese
Copy link
Copy Markdown
Contributor Author

djhoese commented Oct 24, 2025

I see a pandas nightly environment, but does that include numpy nightly? Is there a separate "all nightly" environment?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 24, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

      9 files  ±0        9 suites  ±0   3h 9m 36s ⏱️ - 1m 9s
 18 126 tests ±0   16 911 ✅ ±0   1 215 💤 ±0  0 ❌ ±0 
162 362 runs  ±0  150 283 ✅ +1  12 079 💤  - 1  0 ❌ ±0 

Results for commit b487cb2. ± Comparison against base commit d5b0716.

♻️ This comment has been updated with latest results.

@dcherian dcherian added the run-upstream Add this label to run the upstream-dev job on PRs in CI. label Oct 24, 2025
@jrbourbeau jrbourbeau added upstream and removed run-upstream Add this label to run the upstream-dev job on PRs in CI. labels Oct 24, 2025
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djhoese. I've added the upstream label (which will now run our CI with a bunch of nightly package versions -- including numpy) on any future commits. So if you push an empty commit you should see that build run. You can also include test-upstream in any commit message, which will also trigger that build.

@djhoese
Copy link
Copy Markdown
Contributor Author

djhoese commented Oct 24, 2025

Looks like a single unrelated failure (pyarrow):

 ____________________________ test_parquet[pyarrow] _____________________________
[gw1] linux -- Python 3.12.12 /home/runner/miniconda3/envs/test-environment/bin/python3.12

engine = 'pyarrow'

    @pytest.mark.network
    @pytest.mark.parametrize(
        "engine",
        ["pyarrow"],
    )
    def test_parquet(engine):
        pytest.importorskip("requests", minversion="2.21.0")
        dd = pytest.importorskip("dask.dataframe")
        pytest.importorskip(engine)
        df = dd.read_parquet(
            [
                "https://github.com/Parquet/parquet-compatibility/raw/"
                "master/parquet-testdata/impala/1.1.1-NONE/"
                "nation.impala.parquet"
            ],
            engine=engine,
>       ).compute()
          ^^^^^^^^^

dask/bytes/tests/test_http.py:189: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
dask/base.py:373: in compute
    (result,) = compute(self, traverse=False, **kwargs)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
dask/base.py:681: in compute
    results = schedule(expr, keys, **kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
dask/dataframe/io/parquet/core.py:82: in __call__
    return read_parquet_part(
dask/dataframe/io/parquet/core.py:184: in read_parquet_part
    func(
dask/dataframe/io/parquet/arrow.py:572: in read_partition
    arrow_table = cls._read_table(
dask/dataframe/io/parquet/arrow.py:1704: in _read_table
    arrow_table = _read_table_from_path(
dask/dataframe/io/parquet/arrow.py:262: in _read_table_from_path
    return pq.ParquetFile(fil, **pre_buffer).read(
../../../miniconda3/envs/test-environment/lib/python3.12/site-packages/pyarrow/parquet/core.py:639: in read
    return self.reader.read_all(column_indices=column_indices,
pyarrow/_parquet.pyx:1860: in pyarrow._parquet.ParquetReader.read_all
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   ???
E   pyarrow.lib.ArrowInvalid: Invalid number of indices: 0

@jrbourbeau jrbourbeau merged commit 52a5349 into dask:main Oct 24, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚠️ Upstream CI failed ⚠️

3 participants