Address collection-based meta arguments in GroupByApply#12099
Merged
jacobtomlinson merged 2 commits intodask:mainfrom Oct 15, 2025
Merged
Address collection-based meta arguments in GroupByApply#12099jacobtomlinson merged 2 commits intodask:mainfrom
meta arguments in GroupByApply#12099jacobtomlinson merged 2 commits intodask:mainfrom
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files + 1 9 suites +1 3h 16m 44s ⏱️ + 22m 37s Results for commit 87489cd. ± Comparison against base commit c039144. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the case that a collection is passed into the
metaargument forGroupByApply. SinceBlockwisedoes not have a dedicated"meta"operand, it will treat this argument as an Expr dependency withinBlockwise._divisions.I'm not entirely sure if there is an easy way to guard against this in a more general way. For now, I just updated the assertion to mention this as a possible cause (in case it pops up in other places).
pre-commit run --all-files