Add input validation on dask.dataframe.read_sql_query()#12091
Merged
jrbourbeau merged 2 commits intodask:mainfrom Oct 3, 2025
Merged
Add input validation on dask.dataframe.read_sql_query()#12091jrbourbeau merged 2 commits intodask:mainfrom
dask.dataframe.read_sql_query()#12091jrbourbeau merged 2 commits intodask:mainfrom
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files ±0 9 suites ±0 3h 10m 43s ⏱️ +57s Results for commit f6c5ea1. ± Comparison against base commit 1a306ba. |
jrbourbeau
approved these changes
Oct 3, 2025
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
LGTM, thanks @jacobtomlinson!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid unexpected errors when accidentally passing a string query to
dask.dataframe.read_sql_query()this PR adds some input validation. To stay as flexible as possible I decided to check for "is not string", the common footgun, instead of "is SQLAlchemy Selectable", but happy to discuss this.Closes #12028