Skip to content

Add distribution check for optional dependencies#12087

Merged
jacobtomlinson merged 1 commit intodask:mainfrom
jrbourbeau:optional-check-update
Oct 8, 2025
Merged

Add distribution check for optional dependencies#12087
jacobtomlinson merged 1 commit intodask:mainfrom
jrbourbeau:optional-check-update

Conversation

@jrbourbeau
Copy link
Copy Markdown
Member

This works for me locally when testing the "local directory named "xarray"` case outlined in #12086

Closes #12086

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

      9 files  ±0        9 suites  ±0   3h 16m 30s ⏱️ + 6m 28s
 18 065 tests ±0   16 848 ✅ ±0   1 217 💤 ±0  0 ❌ ±0 
161 659 runs  ±0  149 541 ✅  - 1  12 118 💤 +1  0 ❌ ±0 

Results for commit 771bcb7. ± Comparison against base commit 3fb02e6.

Copy link
Copy Markdown
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Are we confident that the importable thing isn't the library, like editable installs?

@jacobtomlinson
Copy link
Copy Markdown
Member

It looks like cloning a project onto your Python path will no longer work after this change until you explicitly pip install . in that project. I think that's probably fine but we may have some contributors report this and we need to guide them on setting up their dev environment correctly.

@jacobtomlinson jacobtomlinson merged commit fabab2a into dask:main Oct 8, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dask thinks it loaded Xarray even if none installed since dask._compatibility.import_optional_dependency doesn't return None nor False

2 participants