Fix mixed HLG/Expr handling in _ExprSequence._simplify_down#12081
Merged
jacobtomlinson merged 1 commit intodask:mainfrom Sep 24, 2025
Merged
Fix mixed HLG/Expr handling in _ExprSequence._simplify_down#12081jacobtomlinson merged 1 commit intodask:mainfrom
_ExprSequence._simplify_down#12081jacobtomlinson merged 1 commit intodask:mainfrom
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files ±0 9 suites ±0 3h 21m 56s ⏱️ + 3m 37s For more details on these failures, see this check. Results for commit 52491bd. ± Comparison against base commit 417374d. |
jacobtomlinson
approved these changes
Sep 23, 2025
Member
jacobtomlinson
left a comment
There was a problem hiding this comment.
Looks great, thanks for jumping on this @rjzamora
Member
|
One of the jobs failed in what looks like an unexpected way. Rerunning it. |
Member
|
It passed after rerunning. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic in
_ExprSequence._simplify_downonly works when the non-Exprobjects come before properExprobjects in the sequence. This PR implements a simple fix and adds test coverage.Note that the user in dask/distributed#9117 will still get a warning when they mix the Delayed object with a DataFrame expression. However, their reproducer should work with the change in this PR.
pre-commit run --all-files