Skip to content

fix: csc scalar declaration in _array_like_safe#12078

Merged
jacobtomlinson merged 2 commits intodask:mainfrom
ilan-gold:ig/csc_singleton_declaration
Sep 16, 2025
Merged

fix: csc scalar declaration in _array_like_safe#12078
jacobtomlinson merged 2 commits intodask:mainfrom
ilan-gold:ig/csc_singleton_declaration

Conversation

@ilan-gold
Copy link
Copy Markdown
Contributor

@ilan-gold ilan-gold commented Sep 16, 2025

  • Small bug I noticed: scipy.sparse.csc_matrix(numpy.array([0])) throws an error complaining about the dimension of the input.
  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 16, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

      9 files  ± 0        9 suites  ±0   3h 13m 46s ⏱️ + 2m 33s
 18 062 tests + 2   16 843 ✅ ± 0   1 217 💤 ±0  2 ❌ +2 
161 632 runs  +18  149 513 ✅ +17  12 117 💤  - 1  2 ❌ +2 

For more details on these failures, see this check.

Results for commit dbeedff. ± Comparison against base commit 7f3596b.

This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both. 
dask.array.tests.test_array_core ‑ test_dask_array_setitem_singleton_sparse[array]
dask.array.tests.test_array_core ‑ test_dask_array_setitem_singleton_sparse[matrix]

dask.array.tests.test_array_core ‑ test_dask_array_setitem_singleton_sparse[csc-array]
dask.array.tests.test_array_core ‑ test_dask_array_setitem_singleton_sparse[csc-matrix]
dask.array.tests.test_array_core ‑ test_dask_array_setitem_singleton_sparse[csr-array]
dask.array.tests.test_array_core ‑ test_dask_array_setitem_singleton_sparse[csr-matrix]

jacobtomlinson
jacobtomlinson approved these changes Sep 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch thanks!

@jacobtomlinson jacobtomlinson merged commit 83ab4e7 into dask:main Sep 16, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ilan-gold @jacobtomlinson