TST: Fix test_enforce_columns on Python 3.14#12047
Merged
jrbourbeau merged 1 commit intodask:mainfrom Aug 18, 2025
Merged
Conversation
Formerly, the `ValueError` would be raised by `DataFrame.__len__` from the tuple unpacking into the function arguments. In Python 3.14, as of python/cpython@5a23994 the `__len__` method is not called and the `ValueError` is not raised. In any case, I don't believe the point of the test is to check `__len__` due to tuple unpacking, but just general column consistency checks. It is thus sufficient to call `dask.compute` on the `DataFrame` as a whole, which will run a column consistency check in all cases.
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files ±0 9 suites ±0 3h 21m 8s ⏱️ - 5m 5s Results for commit 365d148. ± Comparison against base commit d0a9d15. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formerly, the
ValueErrorwould be raised byDataFrame.__len__from the tuple unpacking into the function arguments. In Python 3.14, as of python/cpython@5a23994 the__len__method is not called and theValueErroris not raised.In any case, I don't believe the point of the test is to check
__len__due to tuple unpacking, but just general column consistency checks. It is thus sufficient to calldask.computeon theDataFrameas a whole, which will run a column consistency check in all cases.pre-commit run --all-files