Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

      9 files  ± 0        9 suites  ±0   3h 19m 28s ⏱️ + 3m 28s
 18 037 tests + 3   16 821 ✅ + 3   1 216 💤 ±0  0 ❌ ±0 
161 407 runs  +27  149 300 ✅ +27  12 107 💤 ±0  0 ❌ ±0 

Results for commit 44a467c. ± Comparison against base commit c37e613.

♻️ This comment has been updated with latest results.

Thanks for reviewing @TomAugspurger and good catch!

I added the test you suggested and needed to take out da.percentile from the test function, as it doesn't take axis as an argument (it had been catching a different NotImplementedError before). Found #2824.

While doing this I found the following:

import dask.array as da
import numpy as np

x_np = np.ones(3)
x_da = da.from_array(x_np)

np_percentile_result = np.percentile(x_np, 50) # np.array(1.)
np_nanpercentile_result = np.nanpercentile(x_np, 50) # np.array(1.)
da_percentile_result = da.percentile(x_da, 50).compute() # np.array(1.)
da_nanpercentile_result = da.nanpercentile(x_da, 50).compute() # np.array([1.])

# ok
assert np_percentile_result.shape == np_nanpercentile_result.shape

# ok
assert np_percentile_result.shape == da_nanpercentile_result.shape

# fails
assert np_percentile_result.shape == da.percentile_result.shape

I.e. da.percentile and da.nanpercentile have different behaviours. Will open a separate issue about this.

Thanks @jrbourbeau !