Clarify that describe() uses approximate algorithms#11973
Closed
Clarify that describe() uses approximate algorithms#11973
Conversation
- Adds dask/array/kron.py with the kron function using blockwise for 2D arrays. - Supports fallback to NumPy for 1D, empty, or ND>2 cases. - Includes comprehensive unit tests in tests/test_kron.py (basic, random, and reduction cases). Implementa producto de Kronecker distribuido (kron) para Dask Array - Añade dask/array/kron.py con la función kron usando blockwise para arrays 2D. - Soporta fallback a NumPy para casos 1D, vacíos o ND>2. - Incluye pruebas unitarias variadas en tests/test_kron.py (básicos, aleatorios y reducción).
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 9 files ± 0 9 suites ±0 3h 12m 44s ⏱️ - 1m 11s Results for commit 340eaee. ± Comparison against base commit 87a177d. ♻️ This comment has been updated with latest results. |
Member
jacobtomlinson
left a comment
There was a problem hiding this comment.
This PR has a bunch of unrelated things in it, so I'm guessing it was opened in error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a docstring note to
describe()explaining that Dask uses approximate algorithms (e.g., for percentiles). This addresses issue #10416 and aims to reduce confusion when comparing topandas.describe().pre-commit run --all-files