Skip to content

CreateOverlappingPartitions: Add before and after to prepend name#11965

Merged
rjzamora merged 11 commits intodask:mainfrom
faulaire:main
Sep 16, 2025
Merged

CreateOverlappingPartitions: Add before and after to prepend name#11965
rjzamora merged 11 commits intodask:mainfrom
faulaire:main

Conversation

@faulaire
Copy link
Copy Markdown
Contributor

@faulaire faulaire commented May 24, 2025 •
edited
Loading

@faulaire faulaire changed the title CreateOverlappingPartitionsl Add before and after to prepend name CreateOverlappingPartitions: Add before and after to prepend name May 24, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 24, 2025 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

      9 files  +     4        9 suites  +4   3h 13m 4s ⏱️ + 1h 13m 5s
 18 062 tests +     2   16 845 ✅ +     3   1 217 💤  -     1  0 ❌ ±0 
161 632 runs  +71 838  149 514 ✅ +66 625  12 118 💤 +5 213  0 ❌ ±0 

Results for commit 950ed7f. ± Comparison against base commit 7dfc075.

♻️ This comment has been updated with latest results.

rjzamora
rjzamora reviewed Sep 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for addressing this @faulaire !

You are correct that unique tokenization is the underlying cause of #11963. I left some suggestions to make the fix a bit simpler. Otherwise, this should be good.

I know you pushed this PR a long time ago - Sorry it never got a review!

@faulaire
Copy link
Copy Markdown
Contributor Author

faulaire commented Sep 16, 2025

Thanks so much for addressing this @faulaire !

You are correct that unique tokenization is the underlying cause of #11963. I left some suggestions to make the fix a bit simpler. Otherwise, this should be good.

I know you pushed this PR a long time ago - Sorry it never got a review!

Thanks for your review @rjzamora !

I updated the PR according to your review.

jacobtomlinson
jacobtomlinson reviewed Sep 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CI failure looks relevant to these changes. Could you take a look?

@faulaire
Copy link
Copy Markdown
Contributor Author

faulaire commented Sep 16, 2025

This CI failure looks relevant to these changes. Could you take a look?

Fixed

@rjzamora rjzamora merged commit 6da0e73 into dask:main Sep 16, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson left review comments

@rjzamora rjzamora rjzamora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple independent map_overlap operations on same input with different window sizes produce incorrect prev_part sizes

3 participants

@faulaire @jacobtomlinson @rjzamora