Skip to content

arange loses precision on ~2**63 #11801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phofl merged 1 commit into from
Mar 12, 2025
Merged

arange loses precision on ~2**63 #11801

phofl merged 1 commit into from
Mar 12, 2025

Conversation

@crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Feb 28, 2025 •
edited
Loading

Closes #11706
Honestly I'm not entirely sure that the new algorithm is completely bug free (read: always produces exactly the same output as numpy), but at least the hypothesis tests on array-api-tests are all green. Worth noting that those tests always produce a single chunk.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2025 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

      9 files  ± 0        9 suites  ±0   3h 28m 23s ⏱️ +10s
 17 822 tests + 9   16 607 ✅ + 9   1 215 💤 ±0  0 ❌ ±0 
159 472 runs  +81  147 353 ✅ +73  12 119 💤 +8  0 ❌ ±0 

Results for commit f1d4bc4. ± Comparison against base commit b88fbbb.

This pull request removes 5 and adds 14 tests. Note that renamed tests count towards both. 
dask.array.tests.test_creation ‑ test_arange_very_large_args[0-9223372036854775807-9223372036854765808]
dask.array.tests.test_creation ‑ test_arange_very_large_args[0.0--9131138316486228481--92233720368547759]
dask.array.tests.test_creation ‑ test_arange_very_large_args[0.0-9223372036854775807-9223372036854765808]
dask.array.tests.test_creation ‑ test_arange_very_large_args[9223372036854765808-9223372036854775807-1]
dask.array.tests.test_creation ‑ test_arange_very_large_args[9223372036854775807-9223372036854765808--1]

dask.array.tests.test_creation ‑ test_arange_very_large_args[1--72057594037927945--72057594037927938-1.0]
dask.array.tests.test_creation ‑ test_arange_very_large_args[1--72057594037927945--72057594037927938-1.5]
dask.array.tests.test_creation ‑ test_arange_very_large_args[1-0-9223372036854775807-9223372036854765808]
dask.array.tests.test_creation ‑ test_arange_very_large_args[1-0.0--9131138316486228481--92233720368547759]
dask.array.tests.test_creation ‑ test_arange_very_large_args[1-0.0-9223372036854775807-9223372036854765808]
dask.array.tests.test_creation ‑ test_arange_very_large_args[1-9223372036854765808-9223372036854775807-1]
dask.array.tests.test_creation ‑ test_arange_very_large_args[1-9223372036854775807-9223372036854765808--1]
dask.array.tests.test_creation ‑ test_arange_very_large_args[auto--72057594037927945--72057594037927938-1.0]
dask.array.tests.test_creation ‑ test_arange_very_large_args[auto--72057594037927945--72057594037927938-1.5]
dask.array.tests.test_creation ‑ test_arange_very_large_args[auto-0-9223372036854775807-9223372036854765808]
…

♻️ This comment has been updated with latest results.

@crusaderky
Copy link
Collaborator Author

crusaderky commented Mar 12, 2025

@phofl could you review please?

@phofl phofl merged commit 9789fc6 into dask:main Mar 12, 2025
24 checks passed
@crusaderky crusaderky deleted the arange_huge_int branch March 13, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phofl phofl phofl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

arange crashes for parameters near 2**63

2 participants

@crusaderky @phofl