Skip to content

arange: fix extreme values #11707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phofl merged 6 commits into from
Feb 7, 2025
Merged

arange: fix extreme values #11707

phofl merged 6 commits into from
Feb 7, 2025

Conversation

@crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Jan 30, 2025 •
edited
Loading

Closes #11706

@crusaderky crusaderky marked this pull request as draft January 30, 2025 19:29
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±    0       15 suites  ±0   4h 30m 27s ⏱️ + 7m 10s
 17 700 tests +  513   16 505 ✅ +  511   1 193 💤 ±0  2 ❌ +2 
218 443 runs  +6 669  201 180 ✅ +6 660  17 260 💤 +6  3 ❌ +3 

For more details on these failures, see this check.

Results for commit c52cdba. ± Comparison against base commit c552433.

This pull request removes 10 and adds 523 tests. Note that renamed tests count towards both. 
dask.array.tests.test_creation ‑ test_arange_dtypes[0-1-1-None]
dask.array.tests.test_creation ‑ test_arange_dtypes[1-2-0.5-None]
dask.array.tests.test_creation ‑ test_arange_dtypes[1-2.5-1-None]
dask.array.tests.test_creation ‑ test_arange_dtypes[1.5-2-1-None]
dask.array.tests.test_creation ‑ test_arange_dtypes[start4-stop4-step4-None]
dask.array.tests.test_creation ‑ test_arange_dtypes[start5-stop5-step5-None]
dask.array.tests.test_creation ‑ test_arange_dtypes[start6-stop6-step6-None]
dask.array.tests.test_creation ‑ test_arange_dtypes[start7-stop7-step7-None]
dask.array.tests.test_creation ‑ test_arange_dtypes[start8-stop8-step8-uint32]
dask.array.tests.test_creation ‑ test_arange_dtypes[start9-stop9-step9-uint64]

dask.array.tests.test_creation ‑ test_arange_dtype_force[float32]
dask.array.tests.test_creation ‑ test_arange_dtype_force[float64]
dask.array.tests.test_creation ‑ test_arange_dtype_force[int64]
dask.array.tests.test_creation ‑ test_arange_dtype_force[int8]
dask.array.tests.test_creation ‑ test_arange_dtype_force[uint64]
dask.array.tests.test_creation ‑ test_arange_dtype_force[uint8]
dask.array.tests.test_creation ‑ test_arange_dtype_infer[float-float-float32]
dask.array.tests.test_creation ‑ test_arange_dtype_infer[float-float-float64]
dask.array.tests.test_creation ‑ test_arange_dtype_infer[float-float-float]
dask.array.tests.test_creation ‑ test_arange_dtype_infer[float-float-int64]
…

♻️ This comment has been updated with latest results.

@crusaderky crusaderky changed the title arange: fix extreme values; support kwargs arange: fix extreme values Jan 31, 2025
@crusaderky crusaderky mentioned this pull request Jan 31, 2025
Closed
@crusaderky crusaderky marked this pull request as ready for review January 31, 2025 13:11
@crusaderky
Copy link
Collaborator Author

crusaderky commented Jan 31, 2025

CI failures are unrelated; ready for review and merge

@phofl phofl merged commit d3ff1b6 into dask:main Feb 7, 2025
23 of 26 checks passed
@phofl
Copy link
Collaborator

phofl commented Feb 7, 2025

thx

@crusaderky crusaderky mentioned this pull request Feb 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phofl phofl phofl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

arange crashes for parameters near 2**63

2 participants

@crusaderky @phofl