Skip to content

Only override callback methods if present #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrocklin merged 1 commit into from
Apr 27, 2016
Merged

Only override callback methods if present #1126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions dask/callbacks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,14 @@ class Callback(object):
"""

def __init__(self, start=None, pretask=None, posttask=None, finish=None):
self._start = start
self._pretask = pretask
self._posttask = posttask
self._finish = finish
if start:
self._start = start
if pretask:
self._pretask = pretask
if posttask:
self._posttask = posttask
if finish:
self._finish = finish

@property
def _callback(self):
Expand Down
14 changes: 14 additions & 0 deletions dask/tests/test_callbacks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from dask.async import get_sync
from dask.callbacks import Callback

def test_callback():
flag = [False]

class MyCallback(Callback):
def _start(self, dsk):
flag[0] = True

with MyCallback():
get_sync({'x': 1}, 'x')

assert flag[0] is True