[Dask.order] Ignore data tasks when ordering#10619
Closed
[Dask.order] Ignore data tasks when ordering#10619
Conversation
Collaborator
And wrappers around large on-disk arrays like netcdf/hdf/Zarr! These wrappers are small in memory but represent a large amount of data on disk |
This was referenced Dec 14, 2023
Member
Author
|
Opened #10706 instead since it's a different implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be a little controversial... However, there are frequently topologies (particularly in the array space) that have a dummy task at the bottom of the graph that includes some metadata (e.g. for zarr). In the xarray world, those are frequently embedded numpy arrays.
I believe we should special case such tasks since they can throw off otherwise fine heuristics.
So, why is this controversial
da.from_numpy(np.zeros(100), chunks=20)andda.zeros(100, chunk=20)since the first would literally embed the numpy array into the dask graph while the latter generates the data whenever needed. I'm not sure if this is such a bad thing. It may just be a little surprising but I don't think this will have negative effects.Closes #10618
xref #10535