Prepare drop pack unpack - 2nd attempt#10041
Closed
Conversation
This reverts commit 7efda3b.
Member
Author
|
It might not be a good idea after all to merge this while the pack/unpack protocol still lives since the callable annotation triggers a graph materialization on client side... |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So... #9994 was not my brightest moment. While I cached the
self._split_keysinSimpleShuffleLayerI forgot that thekey in self._split_keysthing is a linear time lookup 🤦♂️ causing graph generation to be abysmally slow.This could be easily verified with micro benchmarks. By using a set here we're back to normal