Revert "Prepare drop packunpack (#9994)"#10037
Merged
Conversation
This reverts commit 4574dc5.
jrbourbeau
approved these changes
Mar 8, 2023
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
This is fine by me. Is there somewhere with more info about the regression?
hendrikmakait
approved these changes
Mar 8, 2023
Member
hendrikmakait
left a comment
There was a problem hiding this comment.
LGTM assuming CI will be green.
Member
|
coiled/benchmarks#706 is the mentioned regression |
fjetter
commented
Mar 8, 2023
Comment on lines
+412
to
+424
| self.annotations = self.annotations or {} | ||
| if "priority" not in self.annotations: | ||
| self.annotations["priority"] = {} | ||
| self.annotations["priority"]["__expanded_annotations__"] = None | ||
| self.annotations["priority"].update({_key: 1 for _key in self.get_split_keys()}) | ||
|
|
||
| def get_split_keys(self): | ||
| if self._split_keys is None: | ||
| self._split_keys = [ | ||
| stringify((self.split_name, part_out, part_in)) | ||
| for part_in in range(self.npartitions_input) | ||
| for part_out in self.parts_out | ||
| ] | ||
| return self._split_keys | ||
| # Return SimpleShuffleLayer "split" keys | ||
| return [ | ||
| stringify((self.split_name, part_out, part_in)) | ||
| for part_in in range(self.npartitions_input) | ||
| for part_out in self.parts_out | ||
| ] |
Member
Author
There was a problem hiding this comment.
I suspect this is causing the regression. What I need for the refactoring is to drop the __expanded_annotations__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4574dc5.
Apparently there was a significant performance regression with #9994 so I suggest reverting it until we figured this out.
cc @hendrikmakait