-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Change default boundary value to "none" for dask map_overlap #8391
Copy link
Copy link
Closed
Labels
arraydiscussionDiscussing a topic with no specific actions yetDiscussing a topic with no specific actions yet
Description
I'd like to propose changing the default value of the boundary keyword argument in map_overlap. The current default is "reflect", and I'd like it to be boundary="none" instead.
Reasons why this would be useful:
- It's much faster. It roughly halves the number of tasks, and the difference in compute time is significant
- There's less of a difference between results from a numpy array, vs the same data in a dask array (numpy doesn't do extra padding around the edges by default, so when we do this with dask, it's not equivalent anymore)
- Users rely on default values to choose something sensible, and I think fast performance should be weighted more highly as a sensible priority.
- Many inner functions already handle edges themselves (eg: scipy.ndimage.gaussian_filter, among many others), in which case it is redundant to handle the edges twice.
dask-image already uses boundary="none" wherever possible. We also see users concerned about performance end up doing a bit of experimentation and ending up here too.
cc @jni @jakirkham
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
arraydiscussionDiscussing a topic with no specific actions yetDiscussing a topic with no specific actions yet