-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
dask.array.linalg.svd does not conform to the Array API spec #10389
Copy link
Copy link
Closed
Labels
arraygood first issueClearly described and easy to accomplish. Good for beginners to the project.Clearly described and easy to accomplish. Good for beginners to the project.
Description
It lacks the full_matrices=True/False kwarg.
dask currently implements the full_matrices=False case, while full_matrices=True is the default in the spec.
It would be nice to at least expose full_matrices=False and raise NotImplementedError when calling full_matrices=True to make Array API consuming code be able to use dask while staying backend agnostic when they only need the full_matrices=False case (which is the most commonly used in my opinion).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
arraygood first issueClearly described and easy to accomplish. Good for beginners to the project.Clearly described and easy to accomplish. Good for beginners to the project.