backport: bitcoin#27298 (use clang 16) #5867
Conversation
faf4aca ci: Use TSan new runtime (llvm-16, take 3) (MarcoFalke) Pull request description: The previous two attempts failed: * llvm-14: Failed in bitcoin#24572 * llvm-15: Failed in bitcoin#26775 However, now that the bug is known and fixed, it should be good to go. See also bitcoin#26775 (comment) ACKs for top commit: fanquake: ACK faf4aca - I still see [this](bitcoin#27298 (comment)) failure on aarch64, but that isn't really a regression, as running this tests was already broken for me. I'll open a separate issue, and we can follow up. Tree-SHA512: 372b53c4d42ca7f527dae4a2b5bc5ab33c816930daf7a3479d20ea7749159a0b19cfd8d76244b95b03130e4a3d12ddbbb74668b8f7e9fc272cf1084f53b7ff9b
| << : *GLOBAL_TASK_TEMPLATE | ||
| container: | ||
| image: ubuntu:focal | ||
| image: ubuntu:lunar |
There was a problem hiding this comment.
I think NACK here? https://fridge.ubuntu.com/2023/12/15/ubuntu-23-04-lunar-lobster-reaches-end-of-life-on-january-25-2024/
Lunar is past EOL
There was a problem hiding this comment.
we do not use cirrus, so, that's not actually important which exactly dist is specified here
There was a problem hiding this comment.
this line is matter: https://github.com/dashpay/dash/pull/5867/files#diff-0fa5cb5863297feef0a044ed7983d9804452cdc83a6382fec3e1e127b9915a30R141
and we use custom repo with llvm -> doesn't matter which exactly version is provided by ubuntu
There was a problem hiding this comment.
Is there a reason why we don't have to bump our ubuntu:focal in contrib/containers/ci/Dockerfile? answered in interim
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merge via merge commit
Issue being fixed or feature implemented
tsan is broken in clang 15 it seems, see bitcoin#26768 which was reverted in bitcoin#26775.
Should fix random failures like https://gitlab.com/dashpay/dash/-/jobs/6135684689
What was done?
bump CI clang to 16
How Has This Been Tested?
Run tsan job in https://gitlab.com/UdjinM6/dash/-/pipelines/1171936963 a couple of times, no race issues
Breaking Changes
hopefully n/a
Checklist: