merge bitcoin#17227...#23580: Qt 5.12.10 #4581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5456054 to
5b5e138
Compare
Collaborator
Author
|
Closing this for now as it's causing confusion and PR won't be needed till Qt5.12 bump. |
|
This pull request has conflicts, please rebase. |
|
This pull request has conflicts, please rebase. |
|
This pull request has conflicts, please rebase. |
|
This pull request has conflicts, please rebase. |
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
approved these changes
Apr 26, 2022
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
UdjinM6
approved these changes
Apr 26, 2022
UdjinM6
left a comment
There was a problem hiding this comment.
ACK (tested on macOS 12.3.1, x86)
(there are few nits which can be fixed later but works as expected otherwise)
Comment on lines
+1
to
+22
There was a problem hiding this comment.
23580: the patch is similar to the one in upstream but it's a bit different
src/qt/addressbookpage.cpp
Outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #4681 so that af88980 can be avoided