Merge bitcoin#17708: prevector: avoid misaligned member accesses #4451
Conversation
5f26855 test: Remove ubsan alignment suppressions (Wladimir J. van der Laan) 9d933ef prevector: avoid misaligned member accesses (Anthony Towns) Pull request description: Ensure prevector data is appropriately aligned. Earlier discussion in bitcoin#17530. **Edit laanwj**: In contrast to bitcoin#17530, it does this without increase in size of any of the coin cache data structures (x86_64, clang) | Struct | (size,align) before | (size,align) after | | ------------- | ------------- | ------- | | Coin | 48, 8 | 48, 8 | | CCoinsCacheEntry | 56, 8 | 56, 8 | | CScript | 32, 1 | 32, 8 | ACKs for top commit: laanwj: ACK 5f26855 practicalswift: ACK 5f26855 jonatack: ACK 5f26855 Tree-SHA512: 98d112d6856f683d5b212410b73f3071d2994f1efb046a2418a35890aa1cf1aa7c96a960fc2e963fa15241e861093c1ea41951cf5b4b5431f88345eb1dd0a98a
|
Why is 54bbfb4 here? Seems to just revert part of the merge? |
No, Actually I have added to suppress below warning which are Dash specific. It has to be resolved at a later stage along with others. In case if is not acceptable, would you prefer to resolve now itself? |
|
Why should we suppress these warnings though? They are proper warnings right that should be fixed? |
54bbfb4 to
11e9ddc
Compare
11e9ddc to
4546381
Compare
|
As we discussed, dash specific errors/warnings has been fixed without suppression. |
4546381 to
3063d17
Compare
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
Backport: Merge bitcoin#17708: prevector: avoid misaligned member accesses
add ubsan supressions for below errors
runtime error: load of value 210, which is not a valid value for type 'bool'
runtime error: null pointer passed as argument 1, which is declared to never be null !=