Skip to content

ci: Disable rpcbind_test in gitlab-ci #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xdustinface wants to merge 1 commit into from
Closed

ci: Disable rpcbind_test in gitlab-ci #3598

xdustinface wants to merge 1 commit into from

Conversation

@xdustinface
Copy link

@xdustinface xdustinface commented Jul 9, 2020 •
edited
Loading

Its not possible to setup default gitlab-ci integration since rpcbind_test.py fails for shared runners in gitlab ci. As this test is also always skipped by our gitlab ci (TestFramework (WARNING): Test Skipped: This test requires IPv6 support.) i guess its ok to disable it in the gitlab ci for now?

Might to be related to bitcoin#17765

@xdustinface
ci: Disable rpcbind_test in gitlab-ci
82472d1 
rpcbind_test.py fails for shared runners in gitlab ci. As this test is currently also always skipped by our gitlab ci (probably because of the network configuration of our gitlab runner there?) i guess its ok to disable it in the gitlab ci for now?
@xdustinface
Copy link
Author

xdustinface commented Jul 9, 2020 •
edited
Loading

It fails with

AssertionError: not({('7f000001', 19180), ('00000000000000000000000000000001', 19180)} == {('00000000000000000000000000000000', 19180)})

here

dash/test/functional/rpcbind_test.py

Line 37 in 82472d1

assert_equal(set(get_bind_addrs(pid)), set(expected))

due to this test

dash/test/functional/rpcbind_test.py

Lines 81 to 82 in 82472d1

self.run_bind_test(['127.0.0.1'], '127.0.0.1', [],
[('::0', defaultport)])

It looks like

dash/test/functional/test_framework/netutil.py

Lines 76 to 85 in 82472d1

def get_bind_addrs(pid):
'''
Get bind addresses as (host,port) tuples for process pid.
'''
inodes = get_socket_inodes(pid)
bind_addrs = []
for conn in netstat('tcp') + netstat('tcp6'):
if conn[3] == STATE_LISTEN and conn[4] in inodes:
bind_addrs.append(conn[1])
return bind_addrs

is just not working properly for some setups. Which causes this wrong "host,port" tuple -> ('7f000001', 19180)

and on top it looks like this

dash/test/functional/rpcbind_test.py

Lines 81 to 82 in 82472d1

self.run_bind_test(['127.0.0.1'], '127.0.0.1', [],
[('::0', defaultport)])

should rather be

self.run_bind_test(['127.0.0.1'], '127.0.0.1', [], 
     [('::1', defaultport)])

Im not sure at all so this would require some investigation from my side.. maybe someone else has a clue already?

@xdustinface xdustinface mentioned this pull request Jul 9, 2020
Closed
@UdjinM6 UdjinM6 mentioned this pull request Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xdustinface