Merge remaining bits of #11824: Block ActivateBestChain to empty validationinterface queue #3376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…face queue 97d2b09 Add helper to wait for validation interface queue to catch up (Matt Corallo) 3613749 Block ActivateBestChain to empty validationinterface queue (Matt Corallo) 5a933ce Add an interface to get the queue depth out of CValidationInterface (Matt Corallo) a99b76f Require no cs_main lock for ProcessNewBlock/ActivateBestChain (Matt Corallo) a734896 Avoid cs_main in net_processing ActivateBestChain calls (Matt Corallo) 66aa1d5 Refactor ProcessGetData in anticipation of avoiding cs_main for ABC (Matt Corallo) 818075a Create new mutex for orphans, no cs_main in PLV::BlockConnected (Matt Corallo) Pull request description: This should fix bitcoin#11822. It ended up bigger than I hoped for, but its not too gnarly. Note that " Require no cs_main lock for ProcessNewBlock/ActivateBestChain" is mostly pure code-movement. Tree-SHA512: 1127688545926f6099449dca6a4e6609eefc3abbd72f1c66e03d32bd8c7b31e82097d8307822cfd1dec0321703579cfdd82069cab6e17b1024e75eac694122cb
|
Just a few minor things that got lost: 65ddd34 |
Author
|
@codablock Whitespace changes are kind of unrelated (but I'm fine with fixing it here). |
|
@UdjinM6 Ah I see, I thought these were fixes pre-11824. |
|
fyi, test failure is unrelated and fixed in #3378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.