Update immer library to current master (0a718d2d76bab6ebdcf43de943bd6c7d2dbfe2f9) #2821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2cafbc to
1572f7c
Compare
Author
|
Initially the PR was updating to f891a27b106030c5bed385f464ee871713528a14, but an additional fix was required to make it compile for ARM. The fix was merged upstream after a few minutes, so this PR now updates immer to 0a718d2d76bab6ebdcf43de943bd6c7d2dbfe2f9 |
UdjinM6
reviewed
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed random crashes with the stacktrace pointing into the immer library. It was not immediately clear why exactly it was crashing as I had no debugger attached, so I currently hope that upgrading immer to the latest version fixes this issue. Looking into the changes in the affecting files (e.g.
src/immer/detail/hamts/node.hpp) there is a chance that these fix potential crashes.