Fix denial of service attack on masternode payments #2070
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if masternode payent votes are not checked for signature validity before changing state of objects you can run into cases where for example an attacker can impersonate to block good votes for that block occur at little to no costs.
fix synced check. Sorry was typing this up on my phone!
|
Makes sense, thanks! However, swapping logic this way is probably a bit too much, I have an alternative solution which I believe should do the work but still mostly preserves the current flow. Pls see #2071. |
|
closing in fav of #2071 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if masternode payent votes are not checked for signature validity before changing state of objects you can run into cases where for example an attacker can impersonate to block good votes for that block occur at little to no costs.