If people want to mix funds, they will pay. This is much better than having "not enough funds" warnings. utACK.

maxTxFee appears to be a parameter that can only be set at startup. Shouldn't this use the max fee specified by the user for the particular transaction ?

There is no way to set max fee via rpc and in GUI user should get a dialog asking him to review his tx before submitting (including fee), so I guess this should be enough.

As a user I think I would expect the fee I entered when requesting the transaction in the GUI to be used rather than the max fee.

I might be missing smth but user does not enter max fee directly. "Choose..." sub-dialog has an option for paying "only required fee" (which is hardcoded) but even this doesn't really apply to PS because of the rounding (and user is informed about this fact in tx confirmation dialog).

If you click the Choose button on the Send page you can enter an exact fee or select one using a slider.

I always use this with bitcoin (because the default fee is too low) and if selected this way I wouldn't be expecting the confirmation window to show a higher fee.

Fees in "Choose..." are either rates actually i.e. not exact fees OR "at least" i.e. min, not max. Actual fees are calculated later and shown in tx confirmation dialog.

The implementation looks fine but I'm not going to ack this because I'm not convinced silently allowing the max fee when the user may have requested other settings is a good idea.

Would be good to get other peoples input on this - @schinzelh ...

Ok, after thinking about it more and considering current price levels (which would mean ~$8-$9 fee with this change), I'm postponing this till 12.2 and until we lower denoms again. We probably need to address the issue in some better way.

closing in fav of #2361