Skip to content

polymorphic classes not using a virtual destructor #3759

@sidhujag

Description

@sidhujag

I get a bunch of warnings on these classes for not having a virtual destructor for BLSWrapper:

https://github.com/dashpay/dash/blob/master/src/bls/bls.h#L34

You should consider adding virtual dtors for CBLSWrapper, it may mean derived classes aren't deleted if base class pointer is deleted.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions