Roll package:vm_service to 13.0.0#2265
Merged
Merged
Conversation
| @@ -1,4 +1,5 @@ | |||
| ## 22.1.0-wip | |||
Contributor
There was a problem hiding this comment.
does this need to be stripped down to 22.1.0? same with pubspec version
Collaborator
Author
There was a problem hiding this comment.
It will when it's time for an actual release. We can roll into the SDK with this as-is.
| @@ -1,6 +1,7 @@ | |||
| ## 3.2.0-wip | |||
Contributor
There was a problem hiding this comment.
The -wip gets removed when we release webdev, so this is okay
kenzieschmoll
approved these changes
Oct 25, 2023
kenzieschmoll
left a comment
Contributor
There was a problem hiding this comment.
two comments about package versions, but lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.