[webdev] Hide --null-safety option#2206
Merged
elliette merged 4 commits intoSep 11, 2023
Merged
Conversation
--null-safety option
Member
Author
|
Thanks for taking a look! Feel free to merge if you're happy with the PR, as I don't have merge access on this repo. |
Contributor
|
Thanks! I'll working on merging this and the other open PRs once the DWDS/WebDev releases have been completed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag is confusing now that
webdevrequires a Dart 3 SDK which doesn't support unsound null safety. To reduce this confusion, this PR hides the--null-safetyflag from the output help messages.I was going to remove use of the flag entirely, but I wasn't sure if the flag is still used internally somehow. Let me know if it doesn't need to be wired up and I'd be happy to remove it :)