Skip to content

Erroneous CLI arguments passed through to dart compile js call. #2527

Description

@natebosch

https://github.com/dart-lang/test/actions/runs/16611570855/job/47163483168?pr=2526

test/runner/precompiled_test.dart: browser tests (setUpAll) (failed)

Process `/opt/hostedtoolcache/dart/3.10.0-43.0.dev/x64/bin/dart compile js --executable_name=/opt/hostedtoolcache/dart/3.10.0-43.0.dev/x64/bin/dart --mark_main_isolate_as_system_isolate --packages=/home/runner/work/test/test/.dart_tool/package_config.json /tmp/browser_testPDBZPX/precompiled.dart --out=precompiled/test.dart.browser_test.dart.js` exited with exitCode 1. Output:
    Compile Dart to JavaScript.
-------------8<-----------------
    
    Error: Unknown option '--executable_name=/opt/hostedtoolcache/dart/3.10.0-43.0.dev/x64/bin/dart'.

This coming through Platform.executableArguments. We also get a --mark_main_isolate_as_system_isolate which doesn't make sense passed to dart compile js.

...Platform.executableArguments,

These arguments started getting forwarded during the null safety migration, so I think it's safe to drop now.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions