-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[CP] Migrate from Goma to RBE #55184
Copy link
Copy link
Closed
Labels
area-infrastructureUse area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.cherry-pick-approvedLabel for approved cherrypick requestLabel for approved cherrypick requestcherry-pick-mergedCherry-pick has been merged to the stable or beta branch.Cherry-pick has been merged to the stable or beta branch.cherry-pick-reviewIssue that need cherry pick triage to approveIssue that need cherry pick triage to approvemerge-to-betamerge-to-stabletriage-automationSee https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot.See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot.
Description
Metadata
Metadata
Labels
area-infrastructureUse area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.cherry-pick-approvedLabel for approved cherrypick requestLabel for approved cherrypick requestcherry-pick-mergedCherry-pick has been merged to the stable or beta branch.Cherry-pick has been merged to the stable or beta branch.cherry-pick-reviewIssue that need cherry pick triage to approveIssue that need cherry pick triage to approvemerge-to-betamerge-to-stabletriage-automationSee https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot.See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Commit(s) to merge
12 commits for stable, 5 commits for beta
Target
stable and beta
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/357324 for stable and https://dart-review.googlesource.com/c/sdk/+/357342 for beta
Issue Description
Dart must switch from Goma to RBE before the shutdown of Goma in the near future. We've already migrated the main channel successfully. However, the beta and stable channels continue to use Goma as the RBE support has not landed on them. Based on our release schedule, the necessary RBE support is not scheduled to land on beta/stable in time for the Goma shutdown. Therefore we need to cherry-pick the needed support to the release channels.
What is the fix
The full set of RBE commits on the main channel since the respective channels needs to be cherry-picked in their entirety. This solution ensures the RBE setup is identical between main (as it is right now) and the release channels, which puts them into a fully supported state.
The release artifacts are unchanged. RBE/Goma must not and is not used for release artifacts. This change affects testing only.
Why cherry-pick
We become unable to run the commit queue and post-submit testing on beta and stable when Goma is shut down. Additionally our new RBE partner team is asking us to turn down our old traffic to ensure we have completed the migration.
Risk
low
The exact same code is tested continuously on the main branch. Only testing is affected, RBE/Goma is not used for the release artifacts, which are unchanged.
The commit queue will test all aspects of this change since it affects testing only.
Issue link(s)
b/296994239
Extra Info
No release needs to be made with these cherry-picks as they are infrastructure only and are invisible to end users. They need to be committed such that other cherry-picks affecting customers can be released.