Skip to content

[CP] [Stable][Beta] Please cherry pick 82520abfb1dd82b36e4a50371e71572b2bd95b73 and 84b38aee393d9afc5f2cc83b8a816230478d0646 #54699

Description

@a-siva

Commit(s) to merge

82520ab and 84b38ae

Target

stable and beta

Prepared changelist for beta/stable

stable - https://dart-review.googlesource.com/c/sdk/+/347650
beta - https://dart-review.googlesource.com/c/sdk/+/347760

Issue Description

The change fixes the following

  • an issue that causes Flutter apps to freeze when breakpoints are added to multiple isolates at the same time
  • an issue that causes Flutter apps to crash during hot reload

What is the fix

  • Use safepoint-safe RwLock for breakpoint locations locks
  • Ensure setting breakpoints is lock-safe

Why cherry-pick

Flutter app developers have encountered these scenarios effecting developer productivity.

Risk

low

Issue link(s)

#54650
flutter/flutter#140878

Extra Info

No response

Metadata

Metadata

Labels

area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.cherry-pick-approvedLabel for approved cherrypick requestcherry-pick-reviewIssue that need cherry pick triage to approvemerge-to-betamerge-to-stable

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions