report undefined operator instead of method for bad +=.

MichaelRFairhurst · commit-bot@chromium.org · commit fa885b3eae17 · 2019-06-14T18:56:07.000Z
Change-Id: Ia28fdb47c80768b011b05edc1e3e7b832f9335e8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105971 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
diff --git a/pkg/analyzer/lib/src/generated/element_resolver.dart b/pkg/analyzer/lib/src/generated/element_resolver.dart
@@ -169,7 +169,7 @@ class ElementResolver extends SimpleAstVisitor<void> {
         if (_shouldReportInvalidMember(staticType, staticMethod)) {
           _recordUndefinedToken(
               staticType.element,
-              StaticTypeWarningCode.UNDEFINED_METHOD,
+              StaticTypeWarningCode.UNDEFINED_OPERATOR,
               operator,
               [methodName, staticType.displayName]);
         }
diff --git a/pkg/analyzer/test/generated/static_type_warning_code_test.dart b/pkg/analyzer/test/generated/static_type_warning_code_test.dart
@@ -1732,7 +1732,7 @@ class B {
   }
 }
 ''', [
-      error(StaticTypeWarningCode.UNDEFINED_METHOD, 58, 2),
+      error(StaticTypeWarningCode.UNDEFINED_OPERATOR, 58, 2),
     ]);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ class ElementResolver extends SimpleAstVisitor<void> {`
`169`	`169`	`if (_shouldReportInvalidMember(staticType, staticMethod)) {`
`170`	`170`	`_recordUndefinedToken(`
`171`	`171`	`staticType.element,`
`172`		`- StaticTypeWarningCode.UNDEFINED_METHOD,`
	`172`	`+ StaticTypeWarningCode.UNDEFINED_OPERATOR,`
`173`	`173`	`operator,`
`174`	`174`	`[methodName, staticType.displayName]);`
`175`	`175`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1732,7 +1732,7 @@ class B {`
`1732`	`1732`	`}`
`1733`	`1733`	`}`
`1734`	`1734`	`''', [`
`1735`		`- error(StaticTypeWarningCode.UNDEFINED_METHOD, 58, 2),`
	`1735`	`+ error(StaticTypeWarningCode.UNDEFINED_OPERATOR, 58, 2),`
`1736`	`1736`	`]);`
`1737`	`1737`	`}`
`1738`	`1738`