Validate not only errors, but also warnings.

scheglov · commit-bot@chromium.org · commit c7b501625e13 · 2020-02-13T21:31:59.000Z
Change-Id: I2c03711061ccd40d1609cf9148f3169b4df847d5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135600 Reviewed-by: Bob Nystrom <rnystrom@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
diff --git a/pkg/test_runner/lib/src/command_output.dart b/pkg/test_runner/lib/src/command_output.dart
@@ -1193,7 +1193,10 @@ mixin _StaticErrorOutput on CommandOutput {
             ? error.isAnalyzer
             : error.isCfe);
 
-    var validation = StaticError.validateExpectations(expected, errors);
+    var validation = StaticError.validateExpectations(
+      expected,
+      [...errors, ...warnings],
+    );
     if (validation == null) return Expectation.pass;
 
     writer?.subsection("static error failures");
diff --git a/tests/language_2/variable/inst_field_initializer1_test.dart b/tests/language_2/variable/inst_field_initializer1_test.dart
@@ -10,6 +10,8 @@ class A {
   //         ^
   // [analyzer] COMPILE_TIME_ERROR.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER
   // [cfe] Can't access 'this' in a field initializer to read 'x'.
+  //         ^
+  // [analyzer] STATIC_WARNING.TOP_LEVEL_INSTANCE_GETTER
 }
 
 void main() {

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,8 @@ class A {`
`10`	`10`	`// ^`
`11`	`11`	`// [analyzer] COMPILE_TIME_ERROR.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER`
`12`	`12`	`// [cfe] Can't access 'this' in a field initializer to read 'x'.`
	`13`	`+ // ^`
	`14`	`+ // [analyzer] STATIC_WARNING.TOP_LEVEL_INSTANCE_GETTER`
`13`	`15`	`}`
`14`	`16`
`15`	`17`	`void main() {`