[dart2js] Add '--golem-x' command-line flag

rakudrama · commit-bot@chromium.org · commit bae5bdefd562 · 2019-07-04T00:20:27.000Z
This flag will be used to determine the experimental parameters for the Golem 'dart2js-x-*' configurations. Change-Id: I4698b9520ce86be997ded00092372d72248bbe8a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108201 Reviewed-by: Nicholas Shahan <nshahan@google.com> Commit-Queue: Stephen Adams <sra@google.com>
diff --git a/pkg/compiler/lib/src/commandline_options.dart b/pkg/compiler/lib/src/commandline_options.dart
@@ -100,6 +100,9 @@ class Flags {
   /// Flag for a combination of flags for 'production' mode.
   static const String benchmarkingProduction = '--benchmarking-production';
 
+  /// Flag for a combination of flags for golem experiment mode.
+  static const String golemExperiment = '--golem-x';
+
   static const String conditionalDirectives = '--conditional-directives';
 
   // The syntax-only level of support for generic methods is included in the
diff --git a/pkg/compiler/lib/src/dart2js.dart b/pkg/compiler/lib/src/dart2js.dart
@@ -456,6 +456,7 @@ Future<api.CompilationResult> compile(List<String> argv,
     new OptionHandler(Flags.omitAsCasts, passThrough),
     new OptionHandler(Flags.laxRuntimeTypeToString, passThrough),
     new OptionHandler(Flags.benchmarkingProduction, passThrough),
+    new OptionHandler(Flags.golemExperiment, passThrough),
 
     // TODO(floitsch): remove conditional directives flag.
     // We don't provide the info-message yet, since we haven't publicly
diff --git a/pkg/compiler/lib/src/options.dart b/pkg/compiler/lib/src/options.dart
@@ -120,6 +120,9 @@ class CompilerOptions implements DiagnosticOptions {
   /// Sets a combination of flags for benchmarking 'production' mode.
   bool benchmarkingProduction = false;
 
+  /// Sets a combination of flags for golem experiment benchmarking mode.
+  bool golemExperiment = false;
+
   /// ID associated with this sdk build.
   String buildId = _UNDETERMINED_BUILD_ID;
 
@@ -359,6 +362,7 @@ class CompilerOptions implements DiagnosticOptions {
       ..allowMockCompilation = _hasOption(options, Flags.allowMockCompilation)
       ..benchmarkingProduction =
           _hasOption(options, Flags.benchmarkingProduction)
+      ..golemExperiment = _hasOption(options, Flags.golemExperiment)
       ..buildId =
           _extractStringOption(options, '--build-id=', _UNDETERMINED_BUILD_ID)
       ..compileForServer = _hasOption(options, Flags.serverMode)
@@ -462,6 +466,11 @@ class CompilerOptions implements DiagnosticOptions {
       omitImplicitChecks = true;
     }
 
+    if (golemExperiment) {
+      // TODO(sra): Set flags implied by '--golem-x'. Initially this will be
+      // --experiment-new-rti, and later NNBD.
+    }
+
     if (optimizationLevel != null) {
       if (optimizationLevel == 0) {
         disableInlining = true;
