Skip to content

Commit 40d544b

Browse files
munificentcommit-bot@chromium.org
authored andcommitted
Always count non-core libs when tracking migration progress.
Now that they're farther along, there's little need to keep them separate. Change-Id: I3dedcf34b97cf5f0645fe429b357a459850d65d5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135740 Auto-Submit: Bob Nystrom <rnystrom@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com>
1 parent 9e2d9ec commit 40d544b

1 file changed

Lines changed: 0 additions & 15 deletions

File tree

tools/migration/bin/progress.dart

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,6 @@ import 'package:migration/src/test_directories.dart';
1919
// TODO(rnystrom): Update this with numbers from migrating some language tests.
2020
const _linesPerDay = 24607;
2121

22-
const _includeNonCoreLibs = false;
23-
24-
const _nonCoreLibs = [
25-
"lib_2/html/",
26-
"lib_2/isolate/",
27-
"lib_2/mirrors/",
28-
"lib_2/profiler/",
29-
"lib_2/wasm/",
30-
"standalone_2/io/",
31-
];
32-
3322
/// Some legacy files test behavior that doesn't apply to NNBD at all which
3423
/// means they don't end up in the migrated directory but are done. We put this
3524
/// comment in the *legacy* file to track that it has been migrated.
@@ -57,10 +46,6 @@ void main(List<String> arguments) {
5746
var migratedLines = 0;
5847

5948
for (var legacyPath in listFiles(dir)) {
60-
if (!_includeNonCoreLibs && _nonCoreLibs.any(legacyPath.startsWith)) {
61-
continue;
62-
}
63-
6449
files++;
6550
var sourceLines = readFileLines(legacyPath);
6651
lines += sourceLines.length;

0 commit comments

Comments
 (0)