Skip to content

Update highlight.js download instructions and resources.#8864

Merged
isoos merged 3 commits into
dart-lang:masterfrom
isoos:hljs
Aug 5, 2025
Merged

Update highlight.js download instructions and resources.#8864
isoos merged 3 commits into
dart-lang:masterfrom
isoos:hljs

Conversation

@isoos

@isoos isoos commented Jul 28, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread third_party/highlight/github-dark.css Outdated
/* purposely ignored */
}

} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at end of file

Comment thread third_party/highlight/github.css Outdated
.hljs-tag {
/* purposely ignored */

} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

@@ -1,3 +1,11 @@
pre code.hljs {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there visual changes associated with this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated before-after screenshots and compared them, the only visible difference seems to be a 1-2 pixels change in the code block's overall height (or rather a change in its bottom margin's size). It doesn't really affect the layout in any other way, I don't think it is important to counter it.

@isoos isoos merged commit 1b9ce31 into dart-lang:master Aug 5, 2025
31 checks passed
@isoos isoos deleted the hljs branch August 5, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants