Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: check didChangeDependencies for avoid-unnecessary-setstate#1188

Merged
incendial merged 2 commits into
masterfrom
update-unnecessary-setstate
Feb 12, 2023
Merged

fix: check didChangeDependencies for avoid-unnecessary-setstate#1188
incendial merged 2 commits into
masterfrom
update-unnecessary-setstate

Conversation

@incendial

Copy link
Copy Markdown
Member

Please write a short comment explaining your change (or "none" for internal only changes)

Add missing check for didChangeDependencies.

@incendial incendial added this to the 5.6.0 milestone Feb 11, 2023
@incendial incendial requested a review from dkrutskikh February 11, 2023 13:53
@incendial incendial self-assigned this Feb 11, 2023
@codecov

codecov Bot commented Feb 11, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1188 (d740adb) into master (d19a1e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1188   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files         359      359           
  Lines        8085     8085           
=======================================
  Hits         6963     6963           
  Misses       1122     1122           
Impacted Files Coverage Δ
...rules_list/avoid_unnecessary_setstate/visitor.dart 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit e2f0dd2 into master Feb 12, 2023
@incendial incendial deleted the update-unnecessary-setstate branch February 12, 2023 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant