Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: correctly handle empty comment sentence for format-comment#1159

Merged
incendial merged 2 commits into
masterfrom
fix-empty-comment-sentence
Jan 23, 2023
Merged

fix: correctly handle empty comment sentence for format-comment#1159
incendial merged 2 commits into
masterfrom
fix-empty-comment-sentence

Conversation

@incendial

Copy link
Copy Markdown
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

@incendial incendial added this to the 5.5.0 milestone Jan 23, 2023
@incendial incendial requested a review from dkrutskikh January 23, 2023 13:28
@incendial incendial self-assigned this Jan 23, 2023
@codecov

codecov Bot commented Jan 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1159 (55c3f12) into master (4affa64) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   85.57%   85.58%           
=======================================
  Files         350      350           
  Lines        7919     7920    +1     
=======================================
+ Hits         6777     6778    +1     
  Misses       1142     1142           
Impacted Files Coverage Δ
...lyzer/rules/rules_list/format_comment/visitor.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 7a40cb3 into master Jan 23, 2023
@incendial incendial deleted the fix-empty-comment-sentence branch January 23, 2023 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants