Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

chore: remove unused code#1157

Merged
incendial merged 4 commits into
masterfrom
clean-unused-code
Feb 3, 2023
Merged

chore: remove unused code#1157
incendial merged 4 commits into
masterfrom
clean-unused-code

Conversation

@incendial

@incendial incendial commented Jan 23, 2023

Copy link
Copy Markdown
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

@incendial incendial added this to the 5.5.0 milestone Jan 23, 2023
@incendial incendial requested a review from dkrutskikh January 23, 2023 11:37
@incendial incendial self-assigned this Jan 23, 2023
@codecov

codecov Bot commented Jan 23, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1157 (2f72030) into master (588a34d) will increase coverage by 0.29%.
The diff coverage is 100.00%.

❗ Current head 2f72030 differs from pull request most recent head 7ba3ef8. Consider uploading reports for the commit 7ba3ef8 to get more accurate results

@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
+ Coverage   85.81%   86.11%   +0.29%     
==========================================
  Files         358      359       +1     
  Lines        8072     8073       +1     
==========================================
+ Hits         6927     6952      +25     
+ Misses       1145     1121      -24
Impacted Files Coverage Δ
lib/src/analyzer_plugin/analyzer_plugin_utils.dart 100.00% <ø> (+29.31%) ⬆️
.../anti_patterns/anti_patterns_list/long_method.dart 100.00% <ø> (ø)
...tterns/anti_patterns_list/long_parameter_list.dart 100.00% <ø> (ø)
...rs/lint_analyzer/anti_patterns/models/pattern.dart 16.66% <ø> (ø)
...ers/lint_analyzer/anti_patterns/pattern_utils.dart 100.00% <ø> (ø)
.../lint_analyzer/anti_patterns/patterns_factory.dart 100.00% <ø> (+16.66%) ⬆️
...de_climate/models/code_climate_issue_category.dart 100.00% <ø> (ø)
...c/analyzers/lint_analyzer/rules/rules_factory.dart 100.00% <ø> (+25.00%) ⬆️
...refer_correct_edge_insets_constructor/visitor.dart 100.00% <ø> (ø)
lib/src/utils/dart_types_utils.dart 90.47% <ø> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial removed this from the 5.5.0 milestone Jan 23, 2023
@incendial incendial marked this pull request as draft January 23, 2023 14:15
@incendial incendial marked this pull request as ready for review January 27, 2023 08:57
@incendial incendial requested a review from dkrutskikh January 27, 2023 08:57
@incendial incendial merged commit 7c62edf into master Feb 3, 2023
@incendial incendial deleted the clean-unused-code branch February 3, 2023 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dkrutskikh dkrutskikh dkrutskikh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@incendial incendial

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@incendial @dkrutskikh