Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: list-all-equatable-fields should be typed common#1141

Merged
incendial merged 1 commit into
dart-code-checker:masterfrom
akaiser:fix-list-all-equatable-fields-should-be-typed-common
Jan 7, 2023
Merged

fix: list-all-equatable-fields should be typed common#1141
incendial merged 1 commit into
dart-code-checker:masterfrom
akaiser:fix-list-all-equatable-fields-should-be-typed-common

Conversation

@akaiser

@akaiser akaiser commented Jan 7, 2023

Copy link
Copy Markdown
Contributor
  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

Initially list-all-equatable-fields was introduced as FlutterRule but properly documented as Common. Now when clicking on Missing declared class fields: XYZ (Documentation) inspection warning, the user ends up in wrong doc path:

Screenshot 2023-01-07 at 02 15 42

@incendial

Copy link
Copy Markdown
Member

@akaiser hi, thank you so much!

@incendial incendial self-requested a review January 7, 2023 09:34
@incendial incendial merged commit 3130a85 into dart-code-checker:master Jan 7, 2023
@akaiser akaiser deleted the fix-list-all-equatable-fields-should-be-typed-common branch January 7, 2023 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants