This repository was archived by the owner on Jul 16, 2023. It is now read-only.
fix: add fail assertion as a valid method to missing_test_assertion rule#1069
Merged
incendial merged 1 commit intoNov 4, 2022
Merged
Conversation
incendial
approved these changes
Nov 4, 2022
Member
|
@orevial thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
What changes did you make? (Give an overview)
Add
failmethod as a valid test assertion for missing_test_assertion as it is a valid way to make an assertion in a test.Is there anything you'd like reviewers to focus on?